SOLR-16150 Provide correct bound zookeeper interface #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always giving localhost, we can return the interface that ZK actually listens on.
anshumg
approved these changes
Apr 11, 2022
| @@ -70,7 +70,7 @@ public String getClientString() { | |||
|
|
|||
| // if the string wasn't passed as zkHost, then use the standalone server we started | |||
| if (zkRun == null) return null; | |||
| return "localhost:" + zkProps.getClientPortAddress().getPort(); | |||
| return zkProps.getClientPortAddress().getHostString() + ":" + zkProps.getClientPortAddress().getPort(); | |||
There was a problem hiding this comment.
LGTM. I was trying to see if we need to switch to using zkProps.getSecureClientPortAddress optionally but couldn't find anything in the ZK javadocs. Also, based on my ZK TLS testing - didn't seem like that was needed.
|
This is great, I've seen this noise output and always find it "alarming" to see! |
risdenk
approved these changes
Apr 12, 2022
|
This needs to be tested with docker containers before merging. |
risdenk
approved these changes
Oct 17, 2022
risdenk
added a commit
that referenced
this pull request
Oct 19, 2022
Instead of always giving localhost, we can return the interface that ZK actually listens on. Co-authored-by: Kevin Risden <krisden@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always giving localhost, we can return the interface that ZK
actually listens on.
https://issues.apache.org/jira/browse/SOLR-16150