SOLR-15356: MergeIndexes should not use UninvertingReader. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change some tests to avoid Lucene's new FieldInfo consistency checks in LUCENE-9334
dsmiley
commented
Apr 20, 2021
| @@ -1765,22 +1765,24 @@ public void testRealtimeGet() throws Exception | |||
| @Test | |||
| public void testUpdateField() throws Exception { | |||
| //no versions | |||
| // Use a simple float field. "price"->"price_c" has problems: SOLR-15357 & SOLR-15358 | |||
| final String field = "price_f"; | |||
There was a problem hiding this comment.
@madrob maybe you are interested in this
bruno-roustant
approved these changes
Apr 21, 2021
madrob
approved these changes
Apr 21, 2021
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
Also change some tests to avoid Lucene's new FieldInfo consistency checks in LUCENE-9334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change some tests to avoid Lucene's new FieldInfo consistency checks in LUCENE-9334
https://issues.apache.org/jira/browse/SOLR-15356
I'm not sure if there's a valid use-case for addIndexes/merge to use UninvertingReader like some sort of non-docValues to getting docValues migration? If that would work (not even sure), it would require merging into an empty index to keep the FieldInfo's consistent.