SOLR-15742: Convert v2 /update APIs to annotations #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solr's been in the slow process of moving its v2 APIs away from the existing apispec/mapping framework towards one that relies on more explicit annotations to specify API properties. This commit converts the APIs from the core.Update apispec file to the "new" framework.
epugh
reviewed
May 18, 2022
| * Api} implementations associated with each RequestHandler, and registers them in an {@link | ||
| * org.apache.solr.api.ApiBag}. Since UpdateRequestHandler is mentioned multiple times in | ||
| * ImplicitPlugins.json (once for each update API: /update, /update/json, etc.), this would cause | ||
| * the v2 APIs to be registered in duplicate. To avoid this, Solr has this RequestHandler, whose |
epugh
reviewed
May 18, 2022
| * | ||
| * <p>Most of these v2 APIs are implemented as pure "pass-throughs" to the v1 code paths, but there | ||
| * are a few exceptions: /update and /update/json are both rewritten to /update/json/docs, and | ||
| * /update/json/commands has its path changed to /update/json. |
There was a problem hiding this comment.
do we need to keep the /update/json/commands, sounds like something that is orphaned/abandoned?
There was a problem hiding this comment.
true, we do not need them anymore
There was a problem hiding this comment.
Ok, removed. Thanks for the prompt guys.
- one needed updated to reflect a change to ImplicitPlugins.json - one helped catch a bug in UpdateAPI that's now fixed - one failure was caused by a larger structural bug that I filed a ticket for, but only work around in this current PR. See SOLR-16205.
gerlowskija
added a commit
to gerlowskija/solr
that referenced
this pull request
Jun 2, 2022
Solr's been in the slow process of moving its v2 APIs away from the existing apispec/mapping framework towards one that relies on more explicit annotations to specify API properties. This commit converts the APIs from the core.config.Params apispec file to the "new" framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API properties. Many have been
converted, but many more still remain.
Solution
This commit takes a chunk out of this work by converting the APIs
from the core.Update apispec file to the "new" framework.
Tests
Some unit tests for the v2->v1 mapping in V2UpdateAPIMappingTest
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.