SOLR-15740: Convert v2 schema-edit APIs to annotations #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solr's been in the slow process of moving its v2 APIs away from the existing apispec/mapping framework towards one that relies on more explicit annotations to specify API properties. This commit converts all of Solr's schema-edit APIs to a single annotation-based endpoint. Note that the details of this conversion cause the introspect output of this API to be lost.
epugh
approved these changes
Jun 7, 2022
gerlowskija
added a commit
that referenced
this pull request
Jun 8, 2022
Solr's been in the slow process of moving its v2 APIs away from the existing apispec/mapping framework towards one that relies on more explicit annotations to specify API properties. This commit converts all of Solr's schema-edit APIs to a single annotation-based endpoint. Note that the details of this conversion cause the introspect output of this API to be lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API properties.
Solution
This commit converts all of Solr's schema-edit APIs to a single
annotation-based endpoint.
Note that the details of this conversion cause the introspect output of
this API to be lost.
Tests
See V2SchemaAPIMappingTest.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.