Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-9661 added missing operations[withField,withValue] for expression on stream operations #934

Merged

Conversation

ackepenek
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-9661

Description

Fixed the withField and withValue usage problem while executing the stream enabled expression.

Solution

Defined the functions for withField and withValue

Tests

expression (withField and withValue) is tested manually.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

screenshot about improvement:

Screenshot from 2022-07-08 02-29-42

Screenshot from 2022-07-08 02-29-22

@epugh
Copy link
Contributor

epugh commented Jul 8, 2022

I tested, and this does now run when you pick the "explanation" option. I wish we had a unit test...

@epugh epugh self-assigned this Jul 8, 2022
@epugh
Copy link
Contributor

epugh commented Jul 8, 2022

@ackepenek can you look at why the unit test fails?

./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.io.TestLang.testLang" -Ptests.jvms=1 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=46056942D2DD7B4A -Ptests.file.encoding=ISO-8859-1

@ackepenek
Copy link
Contributor Author

ackepenek commented Jul 8, 2022

@epugh I fixed the broken unit test. I also thought that I add a few unit tests for expressions but I found some statement inside of unit tests. I think these unit tests look enough.

@ackepenek
Copy link
Contributor Author

unittest:org.apache.solr.client.solrj.impl.CloudSolrClientTest.testPerReplicaStateCollection is failed but I can not reproduce on my local:
image
Maybe it was temporary

@epugh
Copy link
Contributor

epugh commented Jul 9, 2022

seemed to pass!

@epugh epugh merged commit 0123375 into apache:main Jul 9, 2022
epugh added a commit that referenced this pull request Jul 9, 2022
…n on stream operations (#934)

* added missing operations[withField,withValue] to stream functions

Co-authored-by: epugh@opensourceconnections.com <epugh@opensourceconnections.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants