Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16287 : MapStream - remap tuple value(s) #936

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

danrosher
Copy link
Contributor

@danrosher danrosher commented Jul 12, 2022

https://issues.apache.org/jira/browse/SOLR-16287

Description

Enables atomic updates for update stream by remapping a value to tuple, solr will recognise the map as an atomic update, otherwise update stream simply overwrites. Normal Solr requirements for atomic/in-place updates are still necessary.

Solution

Remap from (k,v) => k -> newKey -> value

e.g. with

map(,"cand_id=add-distinct") , convert stream tuples from

From:
{"cand_id":5718,id:123,v_i:345}
To:
{ id:123, v_i:345, "cand_id": { "add-distinct": 5718 },

Tests

e.g.
With:
new UpdateRequest() .add(id, "1", "a_ss", "foo", "b_i", "1", "c_d", "3.3", "d_b", "true")
Then:
update(collection1,map(tuple(id="1",a_ss="bar"),"a_ss=add-distinct")) will add-distinct 'bar' to a_ss to then contain ['foo','bar']

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh
Copy link
Contributor

epugh commented Jul 14, 2022

Docs are looking nice!

@epugh
Copy link
Contributor

epugh commented Jul 22, 2022

I sent a note to dev mailing list to see if @joel-bernstein can review it ;-) If he can't, I can try, but it's just an area I haven't worked much in!

@epugh
Copy link
Contributor

epugh commented Jul 26, 2022

Let's give it another few days, and then, if I don't review/merge it, can you bug me? Say Thursday??? Thanks for this @danrosher

@danrosher
Copy link
Contributor Author

Will do @epugh . I'll be away for a week after that.

@risdenk
Copy link
Contributor

risdenk commented Oct 27, 2022

@epugh ping ;) slightly more than a week or so. anything left to do here?

@epugh
Copy link
Contributor

epugh commented Oct 31, 2022

FYI, Joel is going to merge this once the new jar for streaming is completed.

Copy link

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR not updated in 60 days
Projects
None yet
3 participants