SOLR-16304 De-annotate some slow tests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Slow annotation from anything that ran faster than 15s on my machine. Also removed Slow annotation from anything that was already Nightly
cpoerschke
reviewed
Jul 22, 2022
cpoerschke
approved these changes
Jul 29, 2022
solr/core/src/test/org/apache/solr/rest/TestManagedFileStorage.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/security/TestAuthorizationFramework.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jul 29, 2022
|
Just checking; is "de-annotate some slow tests" still accurate -- thus it is still used but just not on tests that are not sufficiently slow? |
|
Slow is no longer used at all |
risdenk
approved these changes
Aug 2, 2022
solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java
Outdated
Show resolved
Hide resolved
dsmiley
approved these changes
Aug 2, 2022
madrob
added a commit
that referenced
this pull request
Aug 2, 2022
Removed @LuceneTestCase.Slow test annotation from our code base Some tests were re-annotated as Nightly tests because they are too long Speed up tests: * Scope down work in non-nightly runs and full testing in Nightly mode * Combined use of cluster in single classes to speed up multiple methods * Replaced several polling sleeps with zookeeper watches * Replaced slow waits on async calls with sync calls when not explicitly testing async (cherry picked from commit d41ae28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Slow annotation from anything that ran faster than 15s on my machine.
Also removed Slow annotation from anything that was already Nightly
https://issues.apache.org/jira/browse/SOLR-16304