Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16337: implement Zk metrics #986

Merged
merged 8 commits into from Aug 29, 2022
Merged

Conversation

noblepaul
Copy link
Contributor

@noblepaul noblepaul commented Aug 26, 2022

copied from #972
implement metrics for ZK ops

How to use?

  • start your servers
  • hit the end point http://localhost:8983/solr/admin/metrics?key=solr.node:CONTAINER.zkClient

sample output

{
  "metrics":{
    "solr.node:CONTAINER.zkClient":{
      "watchesFired":29,
      "reads":452,
      "writes":171,
      "bytesRead":1260447,
      "bytesWritten":483353,
      "multiOps":26,
      "cumulativeMultiOps":34,
      "childFetches":139,
      "cumulativeChildrenFetched":388,
      "existsChecks":427,
      "deletes":3}}}

@@ -152,6 +157,23 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) {
}

this.zkController = zkController;
MetricsMap metricsMap = new MetricsMap(zkController.getZkClient().getMetrics());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NULL_DEREFERENCE: object returned by getZkClient(zkController) could be null and is dereferenced at line 160.


Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@noblepaul noblepaul merged commit db23d7d into apache:main Aug 29, 2022
noblepaul added a commit that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant