SOLR-16336: avoid fetching solrconfig.xml & schema.xml for already cached schema and config

[noblepaul]

https://issues.apache.org/jira/browse/SOLR-16336

[sonatype-lift]

💬 11 similar findings have been found in this PR

---

THREAD_SAFETY_VIOLATION: Unprotected write. Non-private method ManagedIndexSchemaFactory.create(...) indirectly writes to field config.overlay outside of synchronization.
Reporting because this access may occur on a background thread.

---

🔎 Expand here to view all instances of this finding

File Path	Line Number
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java	108
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java	118
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java	85
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java	51
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java	90
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java	95
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java	268
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java	541
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java	283
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java	290

Showing 10 of 11 findings. Visit the Lift Web Console to see all.

---

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command	Usage
@sonatype-lift ignore	Leave out the above finding from this PR
@sonatype-lift ignoreall	Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool>	Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

---

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]