SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints

[danrosher]

https://issues.apache.org/jira/browse/SOLR-16361

Description

use double instead of float for mod function query

Solution

use double instead of float for mod function query

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide

[epugh]

Any chance of a unit test demonstrating the problem? It looks like all reasonable Java code, but it would help me see the unit test demonstrating the problem, and then the fix!

[danrosher]

Any chance of a unit test demonstrating the problem? It looks like all reasonable Java code, but it would help me see the unit test demonstrating the problem, and then the fix!

Added a large int cast to float and double to demonstrate the difference/issue, and a unit test for the new mod impl

[dsmiley]

Nice work! Can you add a CHANGES.txt entry under 9.1 improvements -- like "mod() is now accurate with even higher integers above 123456789"

[danrosher]

Nice work! Can you add a CHANGES.txt entry under 9.1 improvements -- like "mod() is now accurate with even higher integers above 123456789"

Thanks! Added entry to CHANGES.txt