Skip to content

Commit

Permalink
improve some doc
Browse files Browse the repository at this point in the history
  • Loading branch information
adrian-wang committed Feb 1, 2016
1 parent 192f8bf commit 12de061
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,17 @@ case class Join(

def selfJoinResolved: Boolean = left.outputSet.intersect(right.outputSet).isEmpty

// if not a natural join, it is resolved. if it is a natural join, we still need to
// eliminate natural before we mark it resolved, but the node should be ready for
// resolution only if everything else is resolved here.
// Joins are only resolved if they don't introduce ambiguous expression ids.
// NaturalJoin should be ready for resolution only if everything else is resolved here
lazy val resolvedExceptNatural: Boolean = {
childrenResolved &&
expressions.forall(_.resolved) &&
selfJoinResolved &&
condition.forall(_.dataType == BooleanType)
}

// Joins are only resolved if they don't introduce ambiguous expression ids.
// if not a natural join, use `resolvedExceptNatural`. if it is a natural join, we still need
// to eliminate natural before we mark it resolved.
override lazy val resolved: Boolean = joinType match {
case NaturalJoin(_) => false
case _ => resolvedExceptNatural
Expand Down

0 comments on commit 12de061

Please sign in to comment.