Skip to content

Commit

Permalink
[MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
This PR fixes a typo in deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala file.

### Why are the changes needed?
To deliver correct explanation about how the placement policy works.

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
UT as specified, although shouldn't influence any functionality since it's in the comment.

Closes #28267 from asclepiusaka/master.

Authored-by: Cong Du <asclepius1993@gmail.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
  • Loading branch information
asclepiusaka authored and srowen committed Apr 22, 2020
1 parent 8b77b31 commit 54b97b2
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* and cpus per task is 1, so the required container number is 15,
* and host ratio is (host1: 30, host2: 30, host3: 20, host4: 10).
*
* 1. If requested container number (18) is more than the required container number (15):
* 1. If the requested container number (18) is more than the required container number (15):
*
* requests for 5 containers with nodes: (host1, host2, host3, host4)
* requests for 5 containers with nodes: (host1, host2, host3)
Expand All @@ -63,16 +63,16 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* follow the method of 1 and 2.
*
* 4. If containers exist and some of them can match the requested localities.
* For example if we have 1 containers on each node (host1: 1, host2: 1: host3: 1, host4: 1),
* For example if we have 1 container on each node (host1: 1, host2: 1: host3: 1, host4: 1),
* and the expected containers on each node would be (host1: 5, host2: 5, host3: 4, host4: 2),
* so the newly requested containers on each node would be updated to (host1: 4, host2: 4,
* host3: 3, host4: 1), 12 containers by total.
*
* 4.1 If requested container number (18) is more than newly required containers (12). Follow
* method 1 with updated ratio 4 : 4 : 3 : 1.
* method 1 with an updated ratio 4 : 4 : 3 : 1.
*
* 4.2 If request container number (10) is more than newly required containers (12). Follow
* method 2 with updated ratio 4 : 4 : 3 : 1.
* 4.2 If request container number (10) is less than newly required containers (12). Follow
* method 2 with an updated ratio 4 : 4 : 3 : 1.
*
* 5. If containers exist and existing localities can fully cover the requested localities.
* For example if we have 5 containers on each node (host1: 5, host2: 5, host3: 5, host4: 5),
Expand Down

0 comments on commit 54b97b2

Please sign in to comment.