[MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment #28267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good but mind taking another look and see if there are some more typos around here? I am sure there are some more typos to fix. |
|
OK, will proofread again later today |
|
@HyukjinKwon read again and fixed several more words. |
|
ok to test |
HyukjinKwon
reviewed
Apr 21, 2020
| @@ -40,7 +40,7 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack | |||
| * and cpus per task is 1, so the required container number is 15, | |||
| * and host ratio is (host1: 30, host2: 30, host3: 20, host4: 10). | |||
| * | |||
| * 1. If requested container number (18) is more than the required container number (15): | |||
| * 1. If the requested container number (18) is more than the required container number (15): | |||
There was a problem hiding this comment.
I think we can remove this the
HyukjinKwon
reviewed
Apr 21, 2020
| * and the expected containers on each node would be (host1: 5, host2: 5, host3: 4, host4: 2), | ||
| * so the newly requested containers on each node would be updated to (host1: 4, host2: 4, | ||
| * host3: 3, host4: 1), 12 containers by total. | ||
| * | ||
| * 4.1 If requested container number (18) is more than newly required containers (12). Follow | ||
| * method 1 with updated ratio 4 : 4 : 3 : 1. | ||
| * method 1 with an updated ratio 4 : 4 : 3 : 1. |
There was a problem hiding this comment.
I think this an can be removed too.
HyukjinKwon
approved these changes
Apr 21, 2020
|
ok to test |
|
Test build #121563 has finished for PR 28267 at commit
|
|
Test build #121564 has finished for PR 28267 at commit
|
|
Close enough - merged to master/3.0 |
srowen
pushed a commit
that referenced
this pull request
Apr 22, 2020
### What changes were proposed in this pull request? This PR fixes a typo in deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala file. ### Why are the changes needed? To deliver correct explanation about how the placement policy works. ### Does this PR introduce any user-facing change? No ### How was this patch tested? UT as specified, although shouldn't influence any functionality since it's in the comment. Closes #28267 from asclepiusaka/master. Authored-by: Cong Du <asclepius1993@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com> (cherry picked from commit 54b97b2) Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a typo in deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala file.
Why are the changes needed?
To deliver correct explanation about how the placement policy works.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT as specified, although shouldn't influence any functionality since it's in the comment.