Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
dongjoon-hyun committed Aug 27, 2018
1 parent bd3f502 commit 83387f6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,11 @@ object ResolveHints {
}
}

private def formatDatabaseName(name: String): String = {
if (conf.caseSensitiveAnalysis) name else name.toLowerCase(Locale.ROOT)
}

private def matchedTableIdentifier(
nameParts: Seq[String],
tableIdent: IdentifierWithDatabase): Boolean = {
tableIdent.database match {
case Some(db) if catalog.globalTempViewManager.database == formatDatabaseName(db) =>
case Some(db) if resolver(catalog.globalTempViewManager.database, db) =>
val identifierList = db :: tableIdent.identifier :: Nil
namePartsWithDatabase(nameParts, catalog.globalTempViewManager.database)
.corresponds(identifierList)(resolver)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,5 +163,11 @@ class ResolveHintsSuite extends AnalysisTest {
Join(ResolvedHint(testRelation, HintInfo(broadcast = true)),
ResolvedHint(testRelation2, HintInfo(broadcast = true)), Inner, None),
caseSensitive = false)

checkAnalysis(
UnresolvedHint("MAPJOIN", Seq("default.TaBlE", "default.table2", "DEfault.TaBlE2"),
table("TaBlE").join(table("TaBlE2"))),
Join(ResolvedHint(testRelation, HintInfo(broadcast = true)), testRelation2, Inner, None),
caseSensitive = true)
}
}

0 comments on commit 83387f6

Please sign in to comment.