Skip to content

Commit

Permalink
[SPARK-12941][SQL][MASTER] Spark-SQL JDBC Oracle dialect fails to map…
Browse files Browse the repository at this point in the history
… string datatypes to Oracle VARCHAR datatype mapping

## What changes were proposed in this pull request?
A test suite added for the bug fix -SPARK 12941; for the mapping of the StringType to corresponding in Oracle

## How was this patch tested?
manual tests done
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Author: thomastechs <thomas.sebastian@tcs.com>
Author: THOMAS SEBASTIAN <thomas.sebastian@tcs.com>

Closes #11489 from thomastechs/thomastechs-12941-master-new.
  • Loading branch information
thomastechs authored and yhuai committed Mar 4, 2016
1 parent 15d57f9 commit f6ac7c3
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -645,4 +645,10 @@ class JDBCSuite extends SparkFunSuite
r => assert(!List("testPass", "testUser").exists(r.toString.contains))
}
}

test("SPARK 12941: The data type mapping for StringType to Oracle") {
val oracleDialect = JdbcDialects.get("jdbc:oracle://127.0.0.1/db")
assert(oracleDialect.getJDBCType(StringType).
map(_.databaseTypeDefinition).get == "VARCHAR2(255)")
}
}

0 comments on commit f6ac7c3

Please sign in to comment.