[SPARK-12941][SQL][MASTER] Spark-SQL JDBC Oracle dialect fails to map string datatypes to Oracle VARCHAR datatype mapping #11489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this new integration suite for creating the docker based test suite for the bug fix in SPARK-12941
Updated this pom.xml with the ojdbc jar related dependency to test the OracleIntegrationSuite related to SPARK-12941 bug fix
… suite addition Updated DockerJDBCIntegrationSuite.scala with the time out interval, as it is required to be atleast 200 sec for Oracle instance to be up
Updated OracleDialect.scala for [SPARK-12941] for the fix of adding a data type mapping to Oracle
…te addition Updated OracleIntegrationSuite.scala for [SPARK-12941] with Oracle Docker test cases
…es and ignore test case Updated the file with style check fixes and ignore test cases, as the ojdbc jar is not present in the maven.
Updated the order of imports
Updating this pom.xml to comment the changes related oracle ojdbc jar dependency as the maven repository does not contain this.
Updated the OracleIntegrationSuite.scala with the doc and override method
updated doc
Updated style check fixes
Updated OracleIntegrationSuite.scala for [SPARK-12941] for the edits in the comments section
Added comments on why the oracle dependency was commented out
Updated DockerJDBCIntegrationSuite.scala- Reverted the timeout and interval parameter to 60 and 1. This would be required to be increased for Oracle based testing.
Updated the comments about the time interval change required in DockerJDBCIntegrationSuite.scala when testing with Oracle tests
Adding a test suite for the SPARK 12941 for the testing of the StringType mapping to Oracle Varchar
|
@yhuai Added the test case for the JDBCSuite.scala as you had mentioned. |
thomastechs
changed the title
|
ok to test. |
|
Test build #52404 has finished for PR 11489 at commit
|
|
test this please |
|
Test build #52434 has finished for PR 11489 at commit
|
|
thanks. Merging to master. |
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2016
… string datatypes to Oracle VARCHAR datatype mapping A test suite added for the bug fix -SPARK 12941; for the mapping of the StringType to corresponding in Oracle manual tests done (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Author: thomastechs <thomas.sebastian@tcs.com> Author: THOMAS SEBASTIAN <thomas.sebastian@tcs.com> Closes #11489 from thomastechs/thomastechs-12941-master-new. (cherry picked from commit f6ac7c3) Signed-off-by: Yin Huai <yhuai@databricks.com> Conflicts: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
… string datatypes to Oracle VARCHAR datatype mapping ## What changes were proposed in this pull request? A test suite added for the bug fix -SPARK 12941; for the mapping of the StringType to corresponding in Oracle ## How was this patch tested? manual tests done (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Author: thomastechs <thomas.sebastian@tcs.com> Author: THOMAS SEBASTIAN <thomas.sebastian@tcs.com> Closes apache#11489 from thomastechs/thomastechs-12941-master-new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A test suite added for the bug fix -SPARK 12941; for the mapping of the StringType to corresponding in Oracle
How was this patch tested?
manual tests done
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)