Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10509][PYSPARK] Reduce excessive param boiler plate code #10216

Closed
wants to merge 17 commits into from
Closed

[SPARK-10509][PYSPARK] Reduce excessive param boiler plate code #10216

wants to merge 17 commits into from

Commits on Dec 9, 2015

  1. Add a copy to new parent function to make it easier to handle custom … 

    …params
    @holdenk
    holdenk committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    564339b View commit details
    Browse the repository at this point in the history

  2. Use the copy to new parent function for custom params

    @holdenk
    holdenk committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    429172b View commit details
    Browse the repository at this point in the history

  3. Add an explicit test for the only copying new parent

    @holdenk
    holdenk committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    a976b78 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2015

  1. Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code

    @holdenk
    holdenk committed Dec 30, 2015
    Configuration menu
    Copy the full SHA
    384fd0d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2016

  1. Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code

    @holdenk
    holdenk committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    8e8cbae View commit details
    Browse the repository at this point in the history

  2. Remove the comments about place holders since now we use them on copy

    @holdenk
    holdenk committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    79642e0 View commit details
    Browse the repository at this point in the history

  3. Add a test that the name/doc/parent got set correctly

    @holdenk
    holdenk committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    e0f3f00 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2016

  1. Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code

    @holdenk
    holdenk committed Jan 11, 2016
    Configuration menu
    Copy the full SHA
    7aecb59 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2016

  1. Merge in master

    @holdenk
    holdenk committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    c4a2919 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2016

  1. Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code

    @holdenk
    holdenk committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    cb7d468 View commit details
    Browse the repository at this point in the history

  2. Remove a whole bunch of no longer relevant a placeholder... statement… 

    …s and update a new param to also use the new copy syntax instead of duplicated text
    @holdenk
    holdenk committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    53edd3d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2016

  1. Copy the params in the init on param base instead

    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    69025f1 View commit details
    Browse the repository at this point in the history

  2. Update shared param codegen to use the param copy logic as well

    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    a39bea5 View commit details
    Browse the repository at this point in the history

  3. Explicitly call _copy_params in the child object so the class resolve… 

    …s correctly
    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    10ed8da View commit details
    Browse the repository at this point in the history

  4. wait that was unecessary

    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    b755008 View commit details
    Browse the repository at this point in the history

  5. remove print and add a comment

    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    0d28922 View commit details
    Browse the repository at this point in the history

  6. Restore accidentatly removed setDefault, add back newline between ini… 

    …t and setters in tree params codegen, regen shared params
    @holdenk
    holdenk committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    8396aef View commit details
    Browse the repository at this point in the history