-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10509][PYSPARK] Reduce excessive param boiler plate code #10216
Closed
holdenk
wants to merge
17
commits into
apache:master
from
holdenk:SPARK-10509-excessive-param-boiler-plate-code
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
564339b
Add a copy to new parent function to make it easier to handle custom …
holdenk 429172b
Use the copy to new parent function for custom params
holdenk a976b78
Add an explicit test for the only copying new parent
holdenk 384fd0d
Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code
holdenk 8e8cbae
Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code
holdenk 79642e0
Remove the comments about place holders since now we use them on copy
holdenk e0f3f00
Add a test that the name/doc/parent got set correctly
holdenk 7aecb59
Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code
holdenk c4a2919
Merge in master
holdenk cb7d468
Merge branch 'master' into SPARK-10509-excessive-param-boiler-plate-code
holdenk 53edd3d
Remove a whole bunch of no longer relevant a placeholder... statement…
holdenk 69025f1
Copy the params in the init on param base instead
holdenk a39bea5
Update shared param codegen to use the param copy logic as well
holdenk 10ed8da
Explicitly call _copy_params in the child object so the class resolve…
holdenk b755008
wait that was unecessary
holdenk 0d28922
remove print and add a comment
holdenk 8396aef
Restore accidentatly removed setDefault, add back newline between ini…
holdenk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can hopefully remain the same.