Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12502][Build][Python] Script /dev/run-tests fails when IBM Java is used #10463

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Dec 24, 2015

fix an exception with IBM JDK by removing update field from a JavaVersion tuple. This is because IBM JDK does not have information on update '_xx'

remove update field from a JavaVersion tuple. This is because IBM JDK does not have information on update '_xx'
@sarutak
Copy link
Member

sarutak commented Dec 24, 2015

ok to test.

@sarutak
Copy link
Member

sarutak commented Dec 24, 2015

add to whitelist.

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #48285 has finished for PR 10463 at commit 8157ee0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #48286 has finished for PR 10463 at commit 8157ee0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class JavaWordBlacklist\n * class JavaDroppedWordsCounter\n * case class AssertNotNull(\n

@sarutak
Copy link
Member

sarutak commented Dec 24, 2015

Now update is not used but it may possibly used in the future. How about leave update and say as follows?

match = re.search('(\d+)\.(\d+)\.(\d+)(_(\d+))?', raw_version_str)
...
update = match.group(5)
if  update is not None:
  update = int(update)

CC: @srowen

@srowen
Copy link
Member

srowen commented Dec 24, 2015

LGTM. I honestly can't imagine changing the test logic based on the patch level. If somehow we did we can add it back.

@sarutak
Copy link
Member

sarutak commented Dec 24, 2015

O.K, I agree. Merging into master and branch-1.6. Thanks @kiszk !

asfgit pushed a commit that referenced this pull request Dec 24, 2015
…a is used

fix an exception with IBM JDK by removing update field from a JavaVersion tuple. This is because IBM JDK does not have information on update '_xx'

Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com>

Closes #10463 from kiszk/SPARK-12502.

(cherry picked from commit 9e85bb7)
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
@asfgit asfgit closed this in 9e85bb7 Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants