[HOTFIX][test-maven][SPARK-12734] Fix bug in Netty exclusions #10693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #49104 has finished for PR 10693 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for a build bug introduced by the Netty exclusion changes in #10672. We can't exclude
io.netty:nettybecause Akka depends on it. There's not a direct conflict betweenio.netty:nettyandio.netty:netty-all, because the former puts classes in theorg.jboss.nettynamespace while the latter uses theio.nettynamespace. However, there still is a conflict betweenorg.jboss.netty:nettyandio.netty:netty, so we need to continue to exclude the JBoss version of that artifact.While the diff here looks somewhat large, note that this is only a revert of a some of the changes from #10672. You can see the net changes in pom.xml at 3119206...5211ab8#diff-600376dffeb79835ede4a0b285078036