-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoutingTablePartition code comment errors(Previous PR cannot be merged) #10804
Conversation
There is an error in description of RoutingTablePartition object. The "edge partition" is encoded in the lower 30 bits of the Int, not 30 bytes of the Int. And the same mistake is made in "position is encoded in the upper 2 bytes of the Int".
…ent_error_zhipwang RoutingTablePartition comment error
This also doesn't merge. I don't think it is any problem with your PR though. I don't think it's my env either since Joseph had the same problem. That's really strange; possibly a Github issue? I had a similar problem last week but it went away. |
Is it possible the branch I created in my fork that makes the problem? Since it's the first time I make a PR so I'm not sure whether it works. |
I don't see any reason to think the branch has a problem. I can't see the underlying git error (just exit code 1). If it doesn't clear up on its own I'll have to also investigate what commands the script runs and see if I can duplicate them. |
um...Thanks for your help~ |
Test build #2392 has finished for PR 10804 at commit
|
Test build #2396 has finished for PR 10804 at commit
|
I also tried and couldn't merge it. |
@zhipwang not sure what's going on, but can you try closing this and deleting the branch and making a new one? or at least rebasing this branch? I have no idea, but maybe it fixes it. Otherwise I'll clone and merge your change directly. It's not a Github issue as we can merge other PRs at the moment. |
OK~ I will try it. Thanks~ |
Maybe I know what's happening. User insidedctm has made a pull here. But somehow, when I forked the master branch several days ago, the errors still existed. It's fixed now in master branch and branch after 1.4. |
There is an error in description of RoutingTablePartition object. The edge partition is encoded in the lower 30 bits of the Int, not 30 bytes of the Int. And the same mistake is made in position is encoded in the upper 2 bytes of the Int.