Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7997][Core]Remove Akka from Spark Core and Streaming #10854

Closed
wants to merge 3 commits into from
Closed

[SPARK-7997][Core]Remove Akka from Spark Core and Streaming #10854

wants to merge 3 commits into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Jan 21, 2016

  • Remove Akka dependency from core. Note: the streaming-akka project still uses Akka.
  • Remove HttpFileServer
  • Remove Akka configs from SparkConf and SSLOptions
  • Rename spark.akka.frameSize to spark.rpc.message.maxSize. I think it's still worth to keep this config because using DirectTaskResult or IndirectTaskResult depends on it.
  • Update comments and docs

@zsxwing
Copy link
Member Author

zsxwing commented Jan 21, 2016

CC @rxin @vanzin

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49828 has finished for PR 10854 at commit 9188ad3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Jan 21, 2016

retest this please

@zsxwing
Copy link
Member Author

zsxwing commented Jan 21, 2016

Looks weird. Not sure why the following errors didn't happen in #10744

[error]  * the type hierarchy of class org.apache.spark.streaming.zeromq.ZeroMQReceiver has changed in new version. Missing types {org.apache.spark.streaming.receiver.ActorHelper}
[error]    filter with: ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.streaming.zeromq.ZeroMQReceiver")
[info] spark-streaming: found 1 potential binary incompatibilities (filtered 37)
[error]  * class org.apache.spark.streaming.receiver.ActorReceiver#Supervisor does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.streaming.receiver.ActorReceiver$Supervisor")

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49833 has finished for PR 10854 at commit 9188ad3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 21, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49838 has finished for PR 10854 at commit 39f21de.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Jan 21, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49860 has finished for PR 10854 at commit 39f21de.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2433 has started for PR 10854 at commit 39f21de.

zsxwing
zsxwing reviewed Jan 22, 2016
View reviewed changes
core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
@@ -175,7 +175,7 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv) extends Logging {
endpoints.keySet().asScala.foreach(unregisterRpcEndpoint)
// Enqueue a message that tells the message loops to stop.
receivers.offer(PoisonPill)
threadpool.shutdown()
threadpool.shutdownNow()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found here didn't interrupt threads previously..

It doesn't need since PoisonPill has been sent. Found an issue in FlumePollingReceiver that could block the message loop.

@zsxwing
Copy link
Member Author

zsxwing commented Jan 22, 2016

Test build #49860 has finished for PR 10854 at commit 39f21de.

This patch fails from timeout after a configured wait of 250m.
This patch merges cleanly.
This patch adds no public classes.

Looks a netty bug. I just set the netty3 version to 3.8.0.Final and then passed the flume tests locally. Since we have been used 3.8.0.Final for a long time, let's keep it rather than downgrading it.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #49908 has finished for PR 10854 at commit bc3c07e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2437 has started for PR 10854 at commit 24f9e7e.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #49911 has finished for PR 10854 at commit 24f9e7e.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Jan 22, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #49921 has finished for PR 10854 at commit 24f9e7e.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 23, 2016

I'm going to merge this. Not sure why Jenkins reported timeout. I looked at the Jenkins logs and tests all passed.

@asfgit asfgit closed this in bc1babd Jan 23, 2016
@zsxwing zsxwing deleted the remove-akka branch January 25, 2016 23:48
@zsxwing zsxwing mentioned this pull request Feb 2, 2016
Closed
asfgit pushed a commit that referenced this pull request Feb 3, 2016
@zsxwing @rxin
[SPARK-7997][CORE] Add rpcEnv.awaitTermination() back to SparkEnv
335f10e 
`rpcEnv.awaitTermination()` was not added in #10854 because some Streaming Python tests hung forever.

This patch fixed the hung issue and added rpcEnv.awaitTermination() back to SparkEnv.

Previously, Streaming Kafka Python tests shutdowns the zookeeper server before stopping StreamingContext. Then when stopping StreamingContext, KafkaReceiver may be hung due to https://issues.apache.org/jira/browse/KAFKA-601, hence, some thread of RpcEnv's Dispatcher cannot exit and rpcEnv.awaitTermination is hung.The patch just changed the shutdown order to fix it.

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #11031 from zsxwing/awaitTermination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsxwing @SparkQA @rxin