Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12932] [Java API] improved error message for java type inference failure #10865

Closed
wants to merge 3 commits into from

Conversation

andygrove
Copy link
Member

No description provided.

@srowen
Copy link
Member

srowen commented Jan 21, 2016

(Link this to your JIRA -- see guidance here first for how to open a PR: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark )

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2432 has finished for PR 10865 at commit f11f1c7.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • throw new UnsupportedOperationException(s\"Cannot infer type for Java class $

@andygrove andygrove changed the title improved error message for java type inference failure [SPARK-12932] [Java API] improved error message for java type inference failure Jan 21, 2016
@rxin
Copy link
Contributor

rxin commented Jan 22, 2016

cc @cloud-fan

@@ -406,7 +406,7 @@ object JavaTypeInference {
expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil
})
} else {
throw new UnsupportedOperationException(s"no encoder found for ${other.getName}")
throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be less than 100 chars wide to fit spark's style guide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have pushed a fix.

On Thu, Jan 21, 2016 at 8:12 PM, Reynold Xin notifications@github.com
wrote:

In
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
#10865 (comment):

@@ -406,7 +406,7 @@ object JavaTypeInference {
expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil
})
} else {

  •        throw new UnsupportedOperationException(s"no encoder found for ${other.getName}")
    
  •        throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant")
    

this needs to be less than 100 chars wide to fit spark's style guide


Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/10865/files#r50498058.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2436 has finished for PR 10865 at commit a85f52b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2440 has finished for PR 10865 at commit a85f52b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2441 has finished for PR 10865 at commit a85f52b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2442 has finished for PR 10865 at commit a85f52b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@rxin
Copy link
Contributor

rxin commented Jan 23, 2016

Looks like there are some test failures?

@SparkQA
Copy link

SparkQA commented Jan 23, 2016

Test build #2444 has finished for PR 10865 at commit a85f52b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@srowen
Copy link
Member

srowen commented Jan 23, 2016

Yeah, these are consistent test failures but they're not due to this change.

@cloud-fan
Copy link
Contributor

looks like it's related to the jenkins machine that run this test?

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 25, 2016

Test build #49980 has finished for PR 10865 at commit a85f52b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s\"Cannot infer type for class $

@srowen
Copy link
Member

srowen commented Jan 25, 2016

Merged to master/1.6

asfgit pushed a commit that referenced this pull request Jan 25, 2016
…e failure

Author: Andy Grove <andygrove73@gmail.com>

Closes #10865 from andygrove/SPARK-12932.

(cherry picked from commit d8e4805)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in d8e4805 Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants