[SPARK-12983] [CORE] [DOC] Correct metrics.properties.template #10902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # "/metrics/applications/json" can be sent seperately to get metrics snapshot of | ||
| # instance master and applications. MetricsServlet may not be configured by self. | ||
| # | ||
| # 5. The MetricsServlet sink is added by default as a sink in master, worker and |
There was a problem hiding this comment.
While we're here...
- in the master
- , and you can send
- json -> JSON
|
LGTM, the rest are neutral or small improvements |
|
Test build #49999 has finished for PR 10902 at commit
|
|
Test build #50018 has finished for PR 10902 at commit
|
|
Unrelated to this pr, triggering a new build. |
|
Jenkins, retest this please. |
|
Test build #50075 has finished for PR 10902 at commit
|
|
cc @srowen and @JoshRosen since this is the spinoff of #10787` |
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some typos or plain unintelligible sentences in the metrics template.