Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13632] [SQL] Move commands.scala to command package #11482

Closed
wants to merge 2 commits into from

Conversation

andrewor14
Copy link
Contributor

What changes were proposed in this pull request?

This patch simply moves things to a new package in an effort to reduce the size of the diff in #11048. Currently the new package only has one file, but in the future we'll add many new commands in SPARK-13139.

How was this patch tested?

Jenkins.

@HyukjinKwon
Copy link
Member

I think you possibly gave a wrong link by mistake. I don't see any relation between this PR and #11408 (or am I missing something?)

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52354 has finished for PR 11482 at commit 44fc0ff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 3, 2016

LGTM - @andrewor14 please update the pr description to fix the link to the pr, before you merge.

@andrewor14
Copy link
Contributor Author

Oops, I fixed the description.

Conflicts:
	sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
	sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala
	sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52408 has finished for PR 11482 at commit ab1b7f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 3, 2016

Merging in master.

@asfgit asfgit closed this in 3edcc40 Mar 3, 2016
@andrewor14 andrewor14 deleted the commands-package branch March 3, 2016 23:27
asfgit pushed a commit that referenced this pull request Mar 4, 2016
## What changes were proposed in this pull request?

This patch simply moves things to existing package `o.a.s.sql.catalyst.parser` in an effort to reduce the size of the diff in #11048. This is conceptually the same as a recently merged patch #11482.

## How was this patch tested?

Jenkins.

Author: Andrew Or <andrew@databricks.com>

Closes #11506 from andrewor14/parser-package.
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

This patch simply moves things to a new package in an effort to reduce the size of the diff in apache#11048. Currently the new package only has one file, but in the future we'll add many new commands in SPARK-13139.

## How was this patch tested?

Jenkins.

Author: Andrew Or <andrew@databricks.com>

Closes apache#11482 from andrewor14/commands-package.
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

This patch simply moves things to existing package `o.a.s.sql.catalyst.parser` in an effort to reduce the size of the diff in apache#11048. This is conceptually the same as a recently merged patch apache#11482.

## How was this patch tested?

Jenkins.

Author: Andrew Or <andrew@databricks.com>

Closes apache#11506 from andrewor14/parser-package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants