[SPARK-13759][SQL] Add IsNotNull constraints for expressions with an inequality #11594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52714 has finished for PR 11594 at commit
|
|
lgtm |
sameeragarwal
force-pushed
the
isnotequal-constraints
branch
2 times, most recently
from
54c3f49
to
84bac4d
Compare
|
Test build #52730 has finished for PR 11594 at commit
|
|
Test build #52729 has finished for PR 11594 at commit
|
|
Test build #52731 has finished for PR 11594 at commit
|
sameeragarwal
force-pushed
the
isnotequal-constraints
branch
from
84bac4d
to
d316a07
Compare
|
Test build #52785 has finished for PR 11594 at commit
|
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…inequality ## What changes were proposed in this pull request? This PR adds support for inferring `IsNotNull` constraints from expressions with an `!==`. More specifically, if an operator has a condition on `a !== b`, we know that both `a` and `b` in the operator output can no longer be null. ## How was this patch tested? 1. Modified a test in `ConstraintPropagationSuite` to test for expressions with an inequality. 2. Added a test in `NullFilteringSuite` for making sure an Inner join with a "non-equal" condition appropriately filters out null from their input. cc nongli Author: Sameer Agarwal <sameer@databricks.com> Closes apache#11594 from sameeragarwal/isnotequal-constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for inferring
IsNotNullconstraints from expressions with an!==. More specifically, if an operator has a condition ona !== b, we know that bothaandbin the operator output can no longer be null.How was this patch tested?
ConstraintPropagationSuiteto test for expressions with an inequality.NullFilteringSuitefor making sure an Inner join with a "non-equal" condition appropriately filters out null from their input.cc @nongli