Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13775] History page sorted by completed time desc by default. #11608

Closed
wants to merge 1 commit into from

Conversation

zhuoliu
Copy link

@zhuoliu zhuoliu commented Mar 9, 2016

What changes were proposed in this pull request?

Originally the page is sorted by AppID by default.
After tests with users' feedback, we think it might be best to sort by completed time (desc).

How was this patch tested?

Manually test, with screenshot as follows.
sorted-by-complete-time-desc

@tgravescs
Copy link
Contributor

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Mar 9, 2016

Test build #52763 has finished for PR 11608 at commit d6c287f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Merged into master. The only thing I'm concerned is that in the future if we add more columns the "4" might not correspond to completion time anymore. But I think either way this patch is a strict improvement over the status quo.

@asfgit asfgit closed this in 238447d Mar 10, 2016
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?
Originally the page is sorted by AppID by default.
After tests with users' feedback, we think it might be best to sort by completed time (desc).

## How was this patch tested?
Manually test, with screenshot as follows.
![sorted-by-complete-time-desc](https://cloud.githubusercontent.com/assets/11683054/13647686/d6dea924-e5fa-11e5-8fc5-68e039b74b6f.png)

Author: zhuol <zhuol@yahoo-inc.com>

Closes apache#11608 from zhuoliu/13775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants