-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13841][SQL] Removes Dataset.collectRows()/takeRows() #11678
[SPARK-13841][SQL] Removes Dataset.collectRows()/takeRows() #11678
Conversation
ASF JIRA down, will add JIRA number to the PR title later. |
440ddd1
to
97a62d6
Compare
Test build #53000 has finished for PR 11678 at commit
|
Test build #53001 has finished for PR 11678 at commit
|
Test build #53005 has finished for PR 11678 at commit
|
Hi, @liancheng . |
Did you already create a JIRA ticket, or you still need to create one? |
LGTM |
cc @mengxr |
@dongjoon-hyun Thanks, will review it later today. |
@rxin Just created one for this and filled it to PR title. I'm merging this to master. |
## What changes were proposed in this pull request? This PR removes two methods, `collectRows()` and `takeRows()`, from `Dataset[T]`. These methods were added in PR apache#11443, and were later considered not useful. ## How was this patch tested? Existing tests should do the work. Author: Cheng Lian <lian@databricks.com> Closes apache#11678 from liancheng/remove-collect-rows-and-take-rows.
## What changes were proposed in this pull request? This PR removes two methods, `collectRows()` and `takeRows()`, from `Dataset[T]`. These methods were added in PR apache#11443, and were later considered not useful. ## How was this patch tested? Existing tests should do the work. Author: Cheng Lian <lian@databricks.com> Closes apache#11678 from liancheng/remove-collect-rows-and-take-rows.
What changes were proposed in this pull request?
This PR removes two methods,
collectRows()
andtakeRows()
, fromDataset[T]
. These methods were added in PR #11443, and were later considered not useful.How was this patch tested?
Existing tests should do the work.