[SPARK-13841][SQL] Removes Dataset.collectRows()/takeRows() #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ASF JIRA down, will add JIRA number to the PR title later. |
liancheng
force-pushed
the
remove-collect-rows-and-take-rows
branch
from
440ddd1
to
97a62d6
Compare
|
Test build #53000 has finished for PR 11678 at commit
|
|
Test build #53001 has finished for PR 11678 at commit
|
|
Test build #53005 has finished for PR 11678 at commit
|
|
Hi, @liancheng . |
|
Did you already create a JIRA ticket, or you still need to create one? |
|
LGTM |
liancheng
changed the title
|
cc @mengxr |
|
@dongjoon-hyun Thanks, will review it later today. |
|
@rxin Just created one for this and filled it to PR title. I'm merging this to master. |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Mar 17, 2016
## What changes were proposed in this pull request? This PR removes two methods, `collectRows()` and `takeRows()`, from `Dataset[T]`. These methods were added in PR apache#11443, and were later considered not useful. ## How was this patch tested? Existing tests should do the work. Author: Cheng Lian <lian@databricks.com> Closes apache#11678 from liancheng/remove-collect-rows-and-take-rows.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This PR removes two methods, `collectRows()` and `takeRows()`, from `Dataset[T]`. These methods were added in PR apache#11443, and were later considered not useful. ## How was this patch tested? Existing tests should do the work. Author: Cheng Lian <lian@databricks.com> Closes apache#11678 from liancheng/remove-collect-rows-and-take-rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes two methods,
collectRows()andtakeRows(), fromDataset[T]. These methods were added in PR #11443, and were later considered not useful.How was this patch tested?
Existing tests should do the work.