[SPARK-13823][SPARK-13397][SPARK-13395] [CORE] More warnings, StandardCharset follow up #11725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53186 has finished for PR 11725 at commit
|
srowen
changed the title
srowen
changed the title
|
Test build #53191 has finished for PR 11725 at commit
|
|
Test build #53193 has finished for PR 11725 at commit
|
|
Test build #53202 has finished for PR 11725 at commit
|
|
Merged to master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…Charset follow up ## What changes were proposed in this pull request? Follow up to apache#11657 - Also update `String.getBytes("UTF-8")` to use `StandardCharsets.UTF_8` - And fix one last new Coverity warning that turned up (use of unguarded `wait()` replaced by simpler/more robust `java.util.concurrent` classes in tests) - And while we're here cleaning up Coverity warnings, just fix about 15 more build warnings ## How was this patch tested? Jenkins tests Author: Sean Owen <sowen@cloudera.com> Closes apache#11725 from srowen/SPARK-13823.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up to #11657
String.getBytes("UTF-8")to useStandardCharsets.UTF_8wait()replaced by simpler/more robustjava.util.concurrentclasses in tests)How was this patch tested?
Jenkins tests