[SPARK-13397] Cleanup transient annotations which aren't being applied #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is covered by #11725 I agree with the changes, except that I think that in the third instance the annotation actually won't make a difference and should be removed. The superclass retains a non-transient reference anyway. |
|
Can one of the admins verify this patch? |
|
I agree that the third annotation can be removed, the reason is the base class DStream has marked it as transient anyway. |
|
Yeah sorry we had a bit of a race condition here. I submitted the PR just before this, and actually didn't realize there was a whole separate JIRA for this one issue. |
|
That's fine, maybe next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This cleanup the transient annotations which aren't being applied. The followings are the warnings
GSchedulerSuite.scala:70: no valid targets for annotation on value tracker - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
@transient tracker: MapOutputTrackerMaster = null)
SerializationDebuggerSuite.scala:222: no valid targets for annotation on value replacementFieldObject - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
class SerializableClassWithWriteReplace(@transient replacementFieldObject: Object)
ReceiverTrackerSuite.scala:108: no valid targets for annotation on value _ssc - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
class RateTestInputDStream(@transient _ssc: StreamingContext)
How was this patch tested?
Manual.
During building, there should be no warning on transient annotation unused.