[SPARK-13924][SQL] officially support multi-insert #11754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hvanhovell |
|
Test build #53274 has finished for PR 11754 at commit
|
|
Cool! LGTM |
|
Merging in master. Thanks. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request?
There is a feature of hive SQL called multi-insert. For example:
```
FROM src
INSERT OVERWRITE TABLE dest1
SELECT key + 1
INSERT OVERWRITE TABLE dest2
SELECT key WHERE key > 2
INSERT OVERWRITE TABLE dest3
SELECT col EXPLODE(arr) exp AS col
...
```
We partially support it currently, with some limitations: 1) WHERE can't reference columns produced by LATERAL VIEW. 2) It's not executed eagerly, i.e. `sql("...multi-insert clause...")` won't take place right away like other commands, e.g. CREATE TABLE.
This PR removes these limitations and make us fully support multi-insert.
## How was this patch tested?
new tests in `SQLQuerySuite`
Author: Wenchen Fan <wenchen@databricks.com>
Closes apache#11754 from cloud-fan/lateral-view.
| @@ -1776,4 +1776,33 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |||
| |FROM (SELECT '{"f1": "value1", "f2": 12}' json, 'hello' as str) test | |||
| """.stripMargin), Row("value1", "12", BigDecimal("3.14"), "hello")) | |||
| } | |||
|
|
|||
| test("multi-insert with lateral view") { | |||
There was a problem hiding this comment.
@cloud-fan how come a test case is added only in the Hive module?
There was a problem hiding this comment.
at that time, we haven't had a clear plan to remove hive dependency, and multi-insert is considered as a hive only feature. Although the parse rule is in catalyst module, I thought we will separate it into hive module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a feature of hive SQL called multi-insert. For example:
We partially support it currently, with some limitations: 1) WHERE can't reference columns produced by LATERAL VIEW. 2) It's not executed eagerly, i.e.
sql("...multi-insert clause...")won't take place right away like other commands, e.g. CREATE TABLE.This PR removes these limitations and make us fully support multi-insert.
How was this patch tested?
new tests in
SQLQuerySuite