Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13643][SQL] Implement SparkSession #12553

Closed
wants to merge 9 commits into from

Conversation

andrewor14
Copy link
Contributor

What changes were proposed in this pull request?

After removing most of HiveContext in 8fc267a we can now move existing functionality in SQLContext to SparkSession. As of this PR SQLContext becomes a simple wrapper that has a SparkSession and delegates all functionality to it.

How was this patch tested?

Jenkins.

@andrewor14
Copy link
Contributor Author

@rxin @yhuai

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56457 has finished for PR 12553 at commit ba8e56a.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

Thank you! This one looks good. Seems MIMA is complaining the following.

[error]  * method getSchema(java.lang.Class)scala.collection.Seq in class org.apache.spark.sql.SQLContext does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.SQLContext.getSchema")

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56468 has finished for PR 12553 at commit 7ccfb38.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56566 has finished for PR 12553 at commit 530f039.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser
    • class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder
    • * [STORED AS file_format | STORED BY storage_handler_class [WITH SERDEPROPERTIES (...)]]
    • case class AddJar(path: String) extends RunnableCommand
    • case class AddFile(path: String) extends RunnableCommand
    • case class CreateTableAsSelectLogicalPlan(
    • case class CreateViewAsSelectLogicalCommand(
    • case class HiveSerDe(
    • class HiveSqlParser(conf: SQLConf, hiveconf: HiveConf) extends AbstractSqlParser
    • class HiveSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf)

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56568 has finished for PR 12553 at commit 530f039.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser
    • class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder
    • * [STORED AS file_format | STORED BY storage_handler_class [WITH SERDEPROPERTIES (...)]]
    • case class AddJar(path: String) extends RunnableCommand
    • case class AddFile(path: String) extends RunnableCommand
    • case class CreateTableAsSelectLogicalPlan(
    • case class CreateViewAsSelectLogicalCommand(
    • case class HiveSerDe(
    • class HiveSqlParser(conf: SQLConf, hiveconf: HiveConf) extends AbstractSqlParser
    • class HiveSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf)

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56575 has finished for PR 12553 at commit 83b131a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56577 has finished for PR 12553 at commit ae8d1fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

LGTM. Thanks. Merging to master.

@asfgit asfgit closed this in a2e8d4f Apr 21, 2016
@andrewor14 andrewor14 deleted the implement-spark-session branch April 21, 2016 21:48
@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #2850 has finished for PR 12553 at commit ae8d1fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #2851 has finished for PR 12553 at commit ae8d1fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants