[SPARK-16035][PYSPARK] Fix SparseVector parser assertion for end parenthesis #13750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreapasqua
changed the title
andreapasqua
changed the title
|
ok to test |
|
LGTM. It is bad that we don't have full coverage here. Given the fact that |
|
Test build #60749 has finished for PR 13750 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
…nthesis ## What changes were proposed in this pull request? The check on the end parenthesis of the expression to parse was using the wrong variable. I corrected that. ## How was this patch tested? Manual test Author: andreapasqua <andrea@radius.com> Closes #13750 from andreapasqua/sparse-vector-parser-assertion-fix. (cherry picked from commit 4c64e88) Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
…nthesis ## What changes were proposed in this pull request? The check on the end parenthesis of the expression to parse was using the wrong variable. I corrected that. ## How was this patch tested? Manual test Author: andreapasqua <andrea@radius.com> Closes #13750 from andreapasqua/sparse-vector-parser-assertion-fix. (cherry picked from commit 4c64e88) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Merged into master and branch-2.0. Thanks! |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 20, 2016
…nthesis ## What changes were proposed in this pull request? The check on the end parenthesis of the expression to parse was using the wrong variable. I corrected that. ## How was this patch tested? Manual test Author: andreapasqua <andrea@radius.com> Closes apache#13750 from andreapasqua/sparse-vector-parser-assertion-fix. (cherry picked from commit 4c64e88) Signed-off-by: Xiangrui Meng <meng@databricks.com> (cherry picked from commit 3f1d730)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The check on the end parenthesis of the expression to parse was using the wrong variable. I corrected that.
How was this patch tested?
Manual test