[#SPARK-16911] Fix the links in the programming guide #14503
Conversation
| @@ -1097,7 +1097,7 @@ for details. | |||
| <tr> | |||
| <td> <b>foreach</b>(<i>func</i>) </td> | |||
| <td> Run a function <i>func</i> on each element of the dataset. This is usually done for side effects such as updating an <a href="#accumulators">Accumulator</a> or interacting with external storage systems. | |||
| <br /><b>Note</b>: modifying variables other than Accumulators outside of the <code>foreach()</code> may result in undefined behavior. See <a href="#ClosuresLink">Understanding closures </a> for more details.</td> | |||
| <br /><b>Note</b>: modifying variables other than Accumulators outside of the <code>foreach()</code> may result in undefined behavior. See <a href="#understanding-closures-a-nameclosureslinka">Understanding closures </a> for more details.</td> | |||
There was a problem hiding this comment.
These anchors don't exist, are you sure about this? or close this PR please
There was a problem hiding this comment.
@srowen : When we see on the documentation: https://spark.apache.org/docs/latest/programming-guide.html#understanding-closures-a-nameclosureslinka Points to the understanding Closure documentation part hence I replaced it here. I have also rechecked it by generating the docs
There was a problem hiding this comment.
Ah right this is an auto-generated anchor. this is OK.
|
@srowen : So can we merge this ? or do I have to make some more changes? |
|
Did you see my last comment? I think we should remove the old migration guides in latest Spark 2 docs. |
|
@srowen : So do we have to remove this whole part? |
|
Personally, I think that any documentation that talks about migrating to a Spark 1.x version can be removed from the 2.x documentation in master. The target of such a migration is also obsolete. You could make this JIRA really about that, as well as fixing the first link as a side effect. |
|
@srowen : I have updated the documentation and here is what it looks like : Please review it ! Thanks :) |
|
Yes, what about removing the streaming/graphx migration guides? they're also about very old versions. |
|
@srowen : I have removed them too and now it looks like this: Graphx Guide :
Streaming Guide:
Please review them ! Thanks :) |
|
Jenkins test this please |
|
Test build #63266 has finished for PR 14503 at commit
|
|
@srowen : Can we merge this now ? |
|
Yes, though we conventionally leave things open for review for a time. You don't need to ping so quickly. |
## What changes were proposed in this pull request? Fix the broken links in the programming guide of the Graphx Migration and understanding closures ## How was this patch tested? By running the test cases and checking the links. Author: Shivansh <shiv4nsh@gmail.com> Closes #14503 from shiv4nsh/SPARK-16911. (cherry picked from commit 6c1ecb1) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0 |
What changes were proposed in this pull request?
Fix the broken links in the programming guide of the Graphx Migration and understanding closures
How was this patch tested?
By running the test cases and checking the links.