-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-17003] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.11 #14586
Conversation
…hriftserver for scala 2.10
Test build #63561 has finished for PR 14586 at commit
|
test this please |
1 similar comment
test this please |
Test build #63562 has finished for PR 14586 at commit
|
Test build #3213 has finished for PR 14586 at commit
|
Test build #3215 has finished for PR 14586 at commit
|
Test build #3214 has finished for PR 14586 at commit
|
Test build #3219 has finished for PR 14586 at commit
|
Test build #3218 has finished for PR 14586 at commit
|
Test build #3220 has finished for PR 14586 at commit
|
Test build #63627 has finished for PR 14586 at commit
|
test this please |
Test build #3221 has finished for PR 14586 at commit
|
The changes here LGTM, but I wonder if we should also update the binary release artifact publishing code at https://github.com/yhuai/spark/blob/b5ccf1aad43d889a06daec3c80dd447cd0166105/dev/create-release/release-build.sh#L190 ? This is a toss-up because it would technically be a change of dependencies for consumers of those artifacts and might break things in case someone is expecting those artifacts to not contain the ThriftServer. |
Actually, nevermind: we should include |
Done |
Test build #63629 has finished for PR 14586 at commit
|
Test build #63647 has finished for PR 14586 at commit
|
Test build #3222 has finished for PR 14586 at commit
|
I am merging this. |
merging to branch 1.6. |
…iftserver for scala 2.11 ## What changes were proposed in this pull request? hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of `-Phive-thfitserver`. I am also fixing the doc. Author: Yin Huai <yhuai@databricks.com> Closes #14586 from yhuai/SPARK-16453-branch-1.6.
…iftserver for scala 2.11 ## What changes were proposed in this pull request? hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of `-Phive-thfitserver`. I am also fixing the doc. Author: Yin Huai <yhuai@databricks.com> Closes apache#14586 from yhuai/SPARK-16453-branch-1.6. (cherry picked from commit 909231d)
What changes were proposed in this pull request?
hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of
-Phive-thfitserver
. I am also fixing the doc.