Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17003] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.11 #14586

Closed
wants to merge 3 commits into from
Closed

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Aug 10, 2016

What changes were proposed in this pull request?

hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of -Phive-thfitserver. I am also fixing the doc.

@SparkQA
Copy link

SparkQA commented Aug 10, 2016

Test build #63561 has finished for PR 14586 at commit cdd80b8.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Aug 10, 2016

test this please

1 similar comment
@yhuai
Copy link
Contributor Author

yhuai commented Aug 10, 2016

test this please

@SparkQA
Copy link

SparkQA commented Aug 10, 2016

Test build #63562 has finished for PR 14586 at commit cdd80b8.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai yhuai changed the title [SPARK-16453] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.10 [SPARK-16453] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.11 Aug 10, 2016
@yhuai yhuai changed the title [SPARK-16453] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.11 [SPARK-17003] [BUILD] [BRANCH-1.6] release-build.sh is missing hive-thriftserver for scala 2.11 Aug 10, 2016
@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3213 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3215 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3214 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3219 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3218 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3220 has finished for PR 14586 at commit cdd80b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #63627 has finished for PR 14586 at commit b5ccf1a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Aug 11, 2016

test this please

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #3221 has finished for PR 14586 at commit b5ccf1a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

The changes here LGTM, but I wonder if we should also update the binary release artifact publishing code at https://github.com/yhuai/spark/blob/b5ccf1aad43d889a06daec3c80dd447cd0166105/dev/create-release/release-build.sh#L190 ? This is a toss-up because it would technically be a change of dependencies for consumers of those artifacts and might break things in case someone is expecting those artifacts to not contain the ThriftServer.

@JoshRosen
Copy link
Contributor

Actually, nevermind: we should include -Phive-thriftserver there as well because I think it's strictly additive and that artifact already has -Phive. Mind adding the flag there, too, then we can merge?

@yhuai
Copy link
Contributor Author

yhuai commented Aug 11, 2016

Done

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #63629 has finished for PR 14586 at commit b5ccf1a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 12, 2016

Test build #63647 has finished for PR 14586 at commit a785c01.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 12, 2016

Test build #3222 has finished for PR 14586 at commit a785c01.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Aug 12, 2016

I am merging this.

@yhuai
Copy link
Contributor Author

yhuai commented Aug 12, 2016

merging to branch 1.6.

asfgit pushed a commit that referenced this pull request Aug 12, 2016
…iftserver for scala 2.11

## What changes were proposed in this pull request?
hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of `-Phive-thfitserver`. I am also fixing the doc.

Author: Yin Huai <yhuai@databricks.com>

Closes #14586 from yhuai/SPARK-16453-branch-1.6.
@yhuai yhuai closed this Aug 12, 2016
zzcclp pushed a commit to zzcclp/spark that referenced this pull request Aug 15, 2016
…iftserver for scala 2.11

## What changes were proposed in this pull request?
hive-thriftserver works with Scala 2.11 (https://issues.apache.org/jira/browse/SPARK-8013). So, let's publish scala 2.11 artifacts with the flag of `-Phive-thfitserver`. I am also fixing the doc.

Author: Yin Huai <yhuai@databricks.com>

Closes apache#14586 from yhuai/SPARK-16453-branch-1.6.

(cherry picked from commit 909231d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants