[SPARK-17203][SQL] data source options should always be case insensitive #14773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #64289 has finished for PR 14773 at commit
|
|
Maybe these options should just case sensitive in general? |
|
Actually I take that back. Just realized we explicitly documented that these options were case insensitive in the data source API. |
| @@ -65,7 +65,7 @@ case class CreateDataSourceTableCommand( | |||
|
|
|||
| var isExternal = true | |||
| val optionsWithPath = | |||
| if (!new CaseInsensitiveMap(options).contains("path") && managedIfNoPath) { | |||
| if (!options.contains("path") && managedIfNoPath) { | |||
There was a problem hiding this comment.
You might want to create a constant for the string "path" as a data source param. It occurs in quite a few places.
|
I'll back on it after we unify the |
| val duplicatedKeys = lowercaseKeys.groupBy(identity).collect { | ||
| case (x, ys) if ys.size > 1 => x | ||
| } | ||
| throw new AnalysisException( |
There was a problem hiding this comment.
Why it is an AnalysisException? This class is only supposed to be used at driver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We don't have a clear definition about When data source options should be case sensitive and when not. Currently
pathis case-insensitive,numFeaturesin LibSVMFileFormat is case-sensitive,maxFilesPerTriggerin FileStreamSource is case-insensitive, etc.Instead of letting every conf decide whether they should be case-sensitive or not themselves, I think it's better to make it clear that all data source options are case-insensitive.
How was this patch tested?
existing tests.