[SPARK-17347][SQL][Examples]Encoder in Dataset example has incorrect type #14901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCat
changed the title
CodingCat
changed the title
|
Test build #64730 has finished for PR 14901 at commit
|
|
Test build #64731 has finished for PR 14901 at commit
|
| @@ -203,7 +203,7 @@ object SparkSQLExample { | |||
| // No pre-defined encoders for Dataset[Map[K,V]], define explicitly | |||
| implicit val mapEncoder = org.apache.spark.sql.Encoders.kryo[Map[String, Any]] | |||
| // Primitive types and case classes can be also defined as | |||
| implicit val stringIntMapEncoder: Encoder[Map[String, Int]] = ExpressionEncoder() | |||
| // implicit val stringIntMapEncoder: Encoder[Map[String, Any]] = ExpressionEncoder() | |||
There was a problem hiding this comment.
This compiled before though, right? you're saying it's unnecessary because of the implicit in the line above? that seems fine but let's delete these 2 lines then.
There was a problem hiding this comment.
I am saying that the comments (L205) seem to indicate that, besides L204, the encoder can be defined as L206 as well. Actually, L206 has the incorrect type (you can find that by removing L204 and compile with the original L206)
so, I fixed the type and comment the line for successful compilation
|
merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Sep 3, 2016
… type ## What changes were proposed in this pull request? We propose to fix the Encoder type in the Dataset example ## How was this patch tested? The PR will be tested with the current unit test cases Author: CodingCat <zhunansjtu@gmail.com> Closes #14901 from CodingCat/SPARK-17347. (cherry picked from commit 97da410) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We propose to fix the Encoder type in the Dataset example
How was this patch tested?
The PR will be tested with the current unit test cases