[SPARK-17369][SQL] MetastoreRelation toJSON throws AssertException due to missing otherCopyArgs #14928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #64812 has finished for PR 14928 at commit
|
|
Can you update the pull request title / description to say more about the actual issue? |
clockfly
changed the title
|
Updated. |
|
retest this please |
|
Test build #64957 has finished for PR 14928 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Sep 6, 2016
…e to missing otherCopyArgs ## What changes were proposed in this pull request? `TreeNode.toJSON` requires a subclass to explicitly override otherCopyArgs to include currying construction arguments, otherwise it reports AssertException telling that the construction argument values' count doesn't match the construction argument names' count. For class `MetastoreRelation`, it has a currying construction parameter `client: HiveClient`, but Spark forgets to add it to the list of otherCopyArgs. ## How was this patch tested? Unit tests. Author: Sean Zhong <seanzhong@databricks.com> Closes #14928 from clockfly/metastore_relation_toJSON. (cherry picked from commit afb3d5d) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
LGTM, merging to master and 2.0! |
|
Seems this breaks 2.0 build. |
|
I will revert it from branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Sep 6, 2016
…on due to missing otherCopyArgs backport #14928 to 2.0 ## What changes were proposed in this pull request? `TreeNode.toJSON` requires a subclass to explicitly override otherCopyArgs to include currying construction arguments, otherwise it reports AssertException telling that the construction argument values' count doesn't match the construction argument names' count. For class `MetastoreRelation`, it has a currying construction parameter `client: HiveClient`, but Spark forgets to add it to the list of otherCopyArgs. ## How was this patch tested? Unit tests. Author: Sean Zhong <seanzhong@databricks.com> Closes #14968 from clockfly/metastore_toJSON_fix_for_spark_2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TreeNode.toJSONrequires a subclass to explicitly override otherCopyArgs to include currying construction arguments, otherwise it reports AssertException telling that the construction argument values' count doesn't match the construction argument names' count.For class
MetastoreRelation, it has a currying construction parameterclient: HiveClient, but Spark forgets to add it to the list of otherCopyArgs.How was this patch tested?
Unit tests.