[SPARK-16439] [SQL] bring back the separator in SQL UI #15106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65412 has finished for PR 15106 at commit
|
|
The question isn't the language of the UI, but of the host OS. I think this just causes the previous problem again, and that seems more important. I don't think we can make this change as is. |
|
I think this patch could actually work. |
|
@srowen The previous problem is caused by using the default locale of host to format the numbers, that sounds perfect by caused some problems. So we fallback to only use English as the locale, it will works well everywhere. |
|
@srowen Could you left an |
|
If @maver1ck is OK with it I am, sure. |
|
LGTM. |
|
Merging this into master and 2.0, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Currently, the SQL metrics looks like `number of rows: 111111111111`, it's very hard to read how large the number is. So a separator was added by #12425, but removed by #14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English. ## How was this patch tested? Existing tests.  Author: Davies Liu <davies@databricks.com> Closes #15106 from davies/metric_sep. (cherry picked from commit e063206) Signed-off-by: Davies Liu <davies.liu@gmail.com>
wgtmac
pushed a commit
to wgtmac/spark
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Currently, the SQL metrics looks like `number of rows: 111111111111`, it's very hard to read how large the number is. So a separator was added by apache#12425, but removed by apache#14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English. ## How was this patch tested? Existing tests.  Author: Davies Liu <davies@databricks.com> Closes apache#15106 from davies/metric_sep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the SQL metrics looks like
number of rows: 111111111111, it's very hard to read how large the number is. So a separator was added by #12425, but removed by #14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English.How was this patch tested?
Existing tests.
