Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2608] fix executor backend launch commond over mesos mode #1513

Closed
wants to merge 13 commits into from

Conversation

scwf
Copy link
Contributor

@scwf scwf commented Jul 21, 2014

mesos scheduler backend use spark-class/spark-executor to launch executor backend, this will lead to problems:
1 when set spark.executor.extraJavaOptions CoarseMesosSchedulerBackend will throw errors because of the launch command "./bin/spark-class org.apache.spark.executor.CoarseGrainedExecutorBackend %s %s %s %s %d").format(basename, extraOpts, driverUrl, offer.getSlaveId.getValue,offer.getHostname, numCores))

2 spark.executor.extraJavaOptions and spark.executor.extraLibraryPath set in sparkconf will not be valid

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

pwendell commented Aug 1, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA tests have started for PR 1513. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17650/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA results for PR 1513:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17650/consoleFull

@tnachen
Copy link
Contributor

tnachen commented Aug 2, 2014

I was considering a similar fix but I wasnt sure if computing all the class paths and options here where the task is submitted is safe versus in spark-class
Where the executor is running is safe. Now thinking about it I think it should usually work but might not when the executor starts to run in another environment as the framework (like in docker). I have a pr with another fix but I think we should use this PR instead for now

@scwf
Copy link
Contributor Author

scwf commented Aug 4, 2014

@pwendell , i can not see the failed unit test info, can you give me some infer

@pwendell
Copy link
Contributor

pwendell commented Aug 6, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1513. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18005/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1513:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18005/consoleFull

@tnachen
Copy link
Contributor

tnachen commented Aug 6, 2014

It looks it's not failing unit tests but can't even compile.

@scwf
Copy link
Contributor Author

scwf commented Aug 6, 2014

it's becaude [SPARK-2260] update Command.scala, i will fix it

@scwf
Copy link
Contributor Author

scwf commented Aug 7, 2014

@pwendell i have fixed compile error, can you retest this pr?

@andrewor14
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA tests have started for PR 1513. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18185/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA results for PR 1513:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18185/consoleFull

@scwf
Copy link
Contributor Author

scwf commented Aug 9, 2014

@pwendell , can you verify this pr? thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants