-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-2608] fix executor backend launch commond over mesos mode #1513
Conversation
Can one of the admins verify this patch? |
Jenkins, test this please. |
QA tests have started for PR 1513. This patch merges cleanly. |
QA results for PR 1513: |
I was considering a similar fix but I wasnt sure if computing all the class paths and options here where the task is submitted is safe versus in spark-class |
@pwendell , i can not see the failed unit test info, can you give me some infer |
Jenkins, retest this please. |
QA tests have started for PR 1513. This patch merges cleanly. |
QA results for PR 1513: |
It looks it's not failing unit tests but can't even compile. |
it's becaude [SPARK-2260] update Command.scala, i will fix it |
@pwendell i have fixed compile error, can you retest this pr? |
test this please |
QA tests have started for PR 1513. This patch merges cleanly. |
QA results for PR 1513: |
@pwendell , can you verify this pr? thanks~ |
mesos scheduler backend use spark-class/spark-executor to launch executor backend, this will lead to problems:
1 when set spark.executor.extraJavaOptions CoarseMesosSchedulerBackend will throw errors because of the launch command "./bin/spark-class org.apache.spark.executor.CoarseGrainedExecutorBackend %s %s %s %s %d").format(basename, extraOpts, driverUrl, offer.getSlaveId.getValue,offer.getHostname, numCores))
2 spark.executor.extraJavaOptions and spark.executor.extraLibraryPath set in sparkconf will not be valid