[SPARK-2022] Fix extra java config to spark class command via mesos

[tnachen]

No description provided.

[SparkQA]

QA tests have started for PR 1622. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17314/consoleFull

[SparkQA]

QA results for PR 1622:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17314/consoleFull

[tnachen]

@kayousterhout I see you're appointed to most of the Mesos/Spark code, wonder if you can take a look at my patch?

[tnachen]

@pwendell I wonder how do I get reviews on patches?

[pwendell]

If you look at the internals of spark-class, I think you want to be setting SPARK_EXECUTOR_OPTS here. Also, I think environment variables should be set via setEnvironment as shown above, not like this.

[pwendell]

Thanks for looking at this, I proposed a slight change but I think overall this is the right place to be fixing this. One other thing - have you tested this on a Mesos cluster? Thanks!

[pwendell]

btw - I think this might overlap with #1513

[tnachen]

Thanks @pwendell I think we should use that, but I'm not that familiar with spark yet so please help verify. Thanks!

[andrewor14]

Hi @tnachen, I think this is resolved. Would you mind closing this PR?

[tnachen]

Will do.