Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2661][bagel]unpersist old processed rdd #1519

Closed
wants to merge 2 commits into from
Closed

[SPARK-2661][bagel]unpersist old processed rdd #1519

wants to merge 2 commits into from

Conversation

adrian-wang
Copy link
Contributor

Unpersist useless rdd during bagel iteration to make full use of memory.

@SparkQA
Copy link

SparkQA commented Jul 22, 2014

QA tests have started for PR 1519. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16940/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 22, 2014

QA results for PR 1519:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16940/consoleFull

@adrian-wang
Copy link
Contributor Author

@ankurdave

mateiz
mateiz reviewed Jul 23, 2014
View reviewed changes
bagel/src/main/scala/org/apache/spark/bagel/Bagel.scala
@@ -72,6 +72,7 @@ object Bagel extends Logging {
var verts = vertices
var msgs = messages
var noActivity = false
var nextUseless: RDD[(K, (V, Array[M]))] = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe call this lastRDD

@mateiz
Copy link
Contributor

mateiz commented Jul 23, 2014

Also, please open a JIRA issue on https://issues.apache.org/jira/browse/SPARK and include it in the pull request's title.

@adrian-wang adrian-wang changed the title [bagel]unpersist old processed rdd [SPARK-2661][bagel]unpersist old processed rdd Jul 24, 2014
@adrian-wang
Copy link
Contributor Author

Hi Matei, I have renamed the variable and created JIRA SPARK-2661 [https://issues.apache.org/jira/browse/SPARK-2661]
@mateiz

@SparkQA
Copy link

SparkQA commented Jul 24, 2014

QA tests have started for PR 1519. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17085/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 24, 2014

QA results for PR 1519:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17085/consoleFull

@asfgit asfgit closed this in 42dfab7 Jul 24, 2014
@mateiz
Copy link
Contributor

mateiz commented Jul 24, 2014

Thanks Adrian, merged this.

@adrian-wang adrian-wang deleted the bagelunpersist branch July 24, 2014 07:18
@adrian-wang
Copy link
Contributor Author

Thanks Matei!

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@adrian-wang @conviva-zz
[SPARK-2661][bagel]unpersist old processed rdd
287f814 
Unpersist useless rdd during bagel iteration to make full use of memory.

Author: Daoyuan <daoyuan.wang@intel.com>

Closes apache#1519 from adrian-wang/bagelunpersist and squashes the following commits:

182c9dd [Daoyuan] rename var nextUseless to lastRDD
87fd3a4 [Daoyuan] bagel unpersist old processed rdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-wang @SparkQA @mateiz