[SPARK-17652] Fix confusing exception message while reserving capacity #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yhuai |
yhuai
reviewed
Sep 23, 2016
| String message = "Cannot reserve additional contiguous bytes in the vectorized reader " + | ||
| "(requested = " + requiredCapacity + " bytes). As a workaround, you can disable the " + | ||
| "vectorized reader by setting " + SQLConf.PARQUET_VECTORIZED_READER_ENABLED().key() + | ||
| " to false."; |
There was a problem hiding this comment.
Is it possible to also explain what's the cause of this error in the error message?
There was a problem hiding this comment.
Shouldn't the first line work: Cannot reserve additional contiguous bytes in the vectorized reader? Do you have something in mind?
There was a problem hiding this comment.
oh, I was thinking if we can explain the reason that fails the allocation instead of just saying we cannot allocate mem.
|
Test build #65852 has finished for PR 15225 at commit
|
|
Test build #3289 has finished for PR 15225 at commit
|
|
LGTM. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2016
## What changes were proposed in this pull request? This minor patch fixes a confusing exception message while reserving additional capacity in the vectorized parquet reader. ## How was this patch tested? Exisiting Unit Tests Author: Sameer Agarwal <sameerag@cs.berkeley.edu> Closes #15225 from sameeragarwal/error-msg. (cherry picked from commit 7c7586a) Signed-off-by: Yin Huai <yhuai@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This minor patch fixes a confusing exception message while reserving additional capacity in the vectorized parquet reader.
How was this patch tested?
Exisiting Unit Tests