[SPARK-16881][MESOS] Migrate Mesos configs to use ConfigEntry #15654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67614 has finished for PR 15654 at commit
|
|
Thanks! One small fix then LGTM |
mgummelt
suggested changes
Oct 31, 2016
| @@ -51,7 +52,7 @@ private[mesos] class MesosClusterDispatcher( | |||
| extends Logging { | |||
|
|
|||
| private val publicAddress = Option(conf.getenv("SPARK_PUBLIC_DNS")).getOrElse(args.host) | |||
| private val recoveryMode = conf.get("spark.deploy.recoveryMode", "NONE").toUpperCase() | |||
| private val recoveryMode = conf.get(RECOVERY_MODE).getOrElse("NONE").toUpperCase() | |||
There was a problem hiding this comment.
Shouldn't the "NONE" default be added to the config builder?
|
Test build #67823 has finished for PR 15654 at commit
|
|
@mgummelt done! 👍 |
|
cc @srowen for merge into master |
|
Merged to master |
|
Thanks @techaddict. Another PR to move the rest of the configs would be very welcome. |
|
@mgummelt yes working on it. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Migrate Mesos configs to use ConfigEntry ## How was this patch tested? Jenkins Tests Author: Sandeep Singh <sandeep@techaddict.me> Closes apache#15654 from techaddict/SPARK-16881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate Mesos configs to use ConfigEntry
How was this patch tested?
Jenkins Tests