[SPARK-18377][SQL] warehouse path should be a static conf #15825
Conversation
|
Test build #68390 has finished for PR 15825 at commit
|
|
retest this please |
|
Test build #68395 has finished for PR 15825 at commit
|
| // Initialize default database if it doesn't already exist | ||
| createDatabase(defaultDbDefinition, ignoreIfExists = true) | ||
| formatDatabaseName(defaultName) | ||
| } |
There was a problem hiding this comment.
To the other reviewers: this is moved to SharedState.scala. The default database is created once and shared by all the sessions.
| createDatabase(defaultDbDefinition, ignoreIfExists = true) | ||
| formatDatabaseName(defaultName) | ||
| } | ||
| protected var currentDb = DEFAULT_DATABASE |
There was a problem hiding this comment.
It might be safer if we call formatDatabaseName like what we did before.
protected var currentDb = formatDatabaseName (DEFAULT_DATABASE)
|
Regarding the code changes, LGTM except a couple of minor comments. BTW, this introduces reasonable external behavior changes. Maybe we need to document it in the release of Spark 2.1 |
|
Test build #68583 has finished for PR 15825 at commit
|
|
retest this please |
|
Test build #68665 has finished for PR 15825 at commit
|
|
Merging in master/branch-2.1. |
|
I added a |
## What changes were proposed in this pull request? it's weird that every session can set its own warehouse path at runtime, we should forbid it and make it a static conf. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes #15825 from cloud-fan/warehouse. (cherry picked from commit 4ac9759) Signed-off-by: Reynold Xin <rxin@databricks.com>
## What changes were proposed in this pull request? it's weird that every session can set its own warehouse path at runtime, we should forbid it and make it a static conf. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#15825 from cloud-fan/warehouse.
What changes were proposed in this pull request?
it's weird that every session can set its own warehouse path at runtime, we should forbid it and make it a static conf.
How was this patch tested?
existing tests.