[SPARK-18188] Add checksum for shuffle blocks #15894
Conversation
|
Test build #68680 has finished for PR 15894 at commit
|
| @@ -92,12 +91,27 @@ public ByteBuffer nioByteBuffer() throws IOException { | |||
| } | |||
|
|
|||
| @Override | |||
| public InputStream createInputStream() throws IOException { | |||
| public InputStream createInputStream(boolean checksum) throws IOException { | |||
There was a problem hiding this comment.
So, is this only for testing? because it's otherwise very expensive to compute, requiring two passes over the file.
If so, should it not be in some more package-private method only and not exposed?
There was a problem hiding this comment.
This is a good question.
Actually we already have checksum along with compression, we could move the decompression a little bit earlier to detect the corruption in block fetcher, will try that soon.
| import java.nio.ByteBuffer; | ||
| import java.nio.channels.FileChannel; | ||
| import java.util.zip.Adler32; |
There was a problem hiding this comment.
would be better to abstract out the checksum functions into some class so it's easier to change in the future.
| @@ -171,14 +179,30 @@ final class ShuffleBlockFetcherIterator( | |||
| override def onBlockFetchSuccess(blockId: String, buf: ManagedBuffer): Unit = { | |||
| // Only add the buffer to results queue if the iterator is not zombie, | |||
| // i.e. cleanup() has not been called yet. | |||
| val in = try { | |||
There was a problem hiding this comment.
note: move this out of callback to not block network pool
|
Due to complexity and overhead here, close it in favor of #15923. |
What changes were proposed in this pull request?
TBD
How was this patch tested?
Existing tests.