[SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION should support comparators #16036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comparators" This reverts commit 3ce057d.
|
LGTM pending jenkins. @dongjoon-hyun lets merge the implementation of |
|
I see. @cloud-fan and @hvanhovell . |
|
Test build #69248 has finished for PR 16036 at commit
|
|
LGTM. Merging to master (2.1 was already reverted). Thanks! |
|
@hvanhovell , could you give me some direction on #15987 before updating? |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…omparators ## What changes were proposed in this pull request? apache#15704 will fail if we use int literal in `DROP PARTITION`, and we have reverted it in branch-2.1. This PR reverts it in master branch, and add a regression test for it, to make sure the master branch is healthy. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16036 from cloud-fan/revert.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…omparators ## What changes were proposed in this pull request? apache#15704 will fail if we use int literal in `DROP PARTITION`, and we have reverted it in branch-2.1. This PR reverts it in master branch, and add a regression test for it, to make sure the master branch is healthy. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16036 from cloud-fan/revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#15704 will fail if we use int literal in
DROP PARTITION, and we have reverted it in branch-2.1.This PR reverts it in master branch, and add a regression test for it, to make sure the master branch is healthy.
How was this patch tested?
new regression test