[SPARK-18356] [ML] KMeans should cache RDD before training #16295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zakbranch Conflicts: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
srowen
reviewed
Dec 15, 2016
| } | ||
|
|
||
| @Since("2.2.0") | ||
| protected def fit(dataset: Dataset[_], handlePersistence: Boolean): KMeansModel = { |
There was a problem hiding this comment.
CC @hhbyyh who I believe suggested this method for consistency
There was a problem hiding this comment.
@hhbyyh, so that means that we should do the same things for others methods:
caching rdd before training for for:
-GaussianMixture.scala
-BisectingKMeans.scala
-LDA.scala
and remove the extrat train() method for all methods in the package < classification > .
There was a problem hiding this comment.
There's another jira focusing on that issue. SPARK-18608. Feel free to share your suggestions in the jira discussion.
|
Test build #3508 has started for PR 16295 at commit |
|
CC @jkbradley for approval |
|
Test build #3510 has finished for PR 16295 at commit
|
|
Merged to master |
|
This looks fine, thanks! |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? According to request of Mr. Joseph Bradley , I did this update of my PR apache#15965 in order to eliminate the extrat fit() method. jkbradley ## How was this patch tested? Pass existing tests Author: Zakaria_Hili <zakahili@gmail.com> Author: HILI Zakaria <zakahili@gmail.com> Closes apache#16295 from ZakariaHili/zakbranch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to request of Mr. Joseph Bradley , I did this update of my PR #15965 in order to eliminate the extrat fit() method.
@jkbradley
How was this patch tested?
Pass existing tests