-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-20177]Document about compression way has some little detail ch… #17498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's OK otherwise
docs/configuration.md
Outdated
</td> | ||
</tr> | ||
<tr> | ||
<td><code>spark.io.compression.codec</code></td> | ||
<td>lz4</td> | ||
<td> | ||
The codec used to compress internal data such as RDD partitions, broadcast variables and | ||
shuffle outputs. By default, Spark provides three codecs: <code>lz4</code>, <code>lzf</code>, | ||
The codec used to compress internal data such as RDD partitions,event log, broadcast variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(missing a space)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a few people, they all don't know, the event log compression methods is spark.io.com pression. Codec.And a few other places it is necessary to modify, more friendly and clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're replying to, but I'm asking you to add the missing space in "partitions,event"
IMHO I thought this is still a not so necessary fix. I would doubt if user really get confused without your fix? You can always correct me since I stand on the of developers :). |
@srowen i add a space |
@jerryshao |
@srowen @jerryshao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's borderline too trivial to add, yes, but I think it's an OK doc improvement.
Test build #3632 has finished for PR 17498 at commit
|
Merged to master |
…anges.
What changes were proposed in this pull request?
Document compression way little detail changes.
1.spark.eventLog.compress add 'Compression will use spark.io.compression.codec.'
2.spark.broadcast.compress add 'Compression will use spark.io.compression.codec.'
3,spark.rdd.compress add 'Compression will use spark.io.compression.codec.'
4.spark.io.compression.codec add 'event log describe'.
eg
Through the documents, I don't know what is compression mode about 'event log'.
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.