[SPARK-16202][SQL][DOC] Follow-up to Correct The Description of CreatableRelationProvider's createRelation #18026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableRelationProvider's createRelation
|
Test build #77045 has finished for PR 18026 at commit
|
gatorsmile
reviewed
May 18, 2017
| * Saves a DataFrame to a destination (using data source-specific parameters) | ||
| * | ||
| * @param mode specifies what happens when the destination already exists | ||
| * @param parameters data source-specific parameters |
There was a problem hiding this comment.
Could you add the descriptions for the other two parameters here? Thanks!
|
LGTM |
|
Test build #77104 has finished for PR 18026 at commit
|
|
Test build #77107 has finished for PR 18026 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 25, 2017
…ableRelationProvider's createRelation ## What changes were proposed in this pull request? Follow-up to SPARK-16202: 1. Remove the duplication of the meaning of `SaveMode` (as one was in fact missing that had proven that the duplication may be incomplete in the future again) 2. Use standard scaladoc tags /cc gatorsmile rxin yhuai (as they were involved previously) ## How was this patch tested? local build Author: Jacek Laskowski <jacek@japila.pl> Closes #18026 from jaceklaskowski/CreatableRelationProvider-SPARK-16202. (cherry picked from commit 5f8ff2f) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
|
Thanks! Merging to master/2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to SPARK-16202:
Remove the duplication of the meaning of
SaveMode(as one was in fact missing that had proven that the duplication may be incomplete in the future again)Use standard scaladoc tags
/cc @gatorsmile @rxin @yhuai (as they were involved previously)
How was this patch tested?
local build